scovich commented on code in PR #8140:
URL: https://github.com/apache/arrow-rs/pull/8140#discussion_r2277293501


##########
parquet-variant/src/variant.rs:
##########
@@ -1286,6 +1286,77 @@ impl TryFrom<(i128, u8)> for Variant<'_, '_> {
     }
 }
 
+// helper to print <invalid> instead of "<invalid>" in debug mode when a 
VariantObject or VariantList contains invalid values.
+struct InvalidVariant;
+
+impl std::fmt::Debug for InvalidVariant {

Review Comment:
   That's what I had at first, but it would print e.g.
   ```
   {
       "invalid": "invalid",
   }
   ```
   Since `"invalid": "invalid"` is valid JSON, it seemed better to have 
something unambiguous:
   ```
   {
       <invalid>: <invalid>,
   }
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to