superserious-dev commented on PR #8081: URL: https://github.com/apache/arrow-rs/pull/8081#issuecomment-3189863769
> Thanks @superserious-dev -- sorry for the delay in reviewing. I left a comment about returning `Variant::Null` vs an error on conversion failure -- let me know what you think That's an interesting idea. One issue could be that a Null value in the Output Variant would represent 2 things: either a) an error in the casting process or b) a Null value in the input. For now, I undid the macro change and did `unwrap` to avoid modifying the macro. Once all the conversions are in, it could be useful unify the error-handling so that they all align on the approach(ie. unwrap vs Err vs Variant::Null). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
