CurtHagenlocher commented on code in PR #3265:
URL: https://github.com/apache/arrow-adbc/pull/3265#discussion_r2277931540
##########
csharp/src/Apache.Arrow.Adbc/Tracing/TracingReader.cs:
##########
@@ -47,7 +47,7 @@ protected virtual void Dispose(bool disposing)
{
}
- public void Dispose()
+ public virtual void Dispose()
Review Comment:
This shouldn't be made `virtual` because the overload above should be
overridden instead (as `DatabricksCompositeReader` is doing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
