MartinNowak commented on code in PR #46976:
URL: https://github.com/apache/arrow/pull/46976#discussion_r2278420565
##########
python/pyarrow/_csv.pyx:
##########
@@ -1370,14 +1374,18 @@ cdef class WriteOptions(_Weakrefable):
__slots__ = ()
def __init__(self, *, include_header=None, batch_size=None,
- delimiter=None, quoting_style=None):
+ delimiter=None, eol=None, null_string=None,
quoting_style=None):
self.options.reset(new CCSVWriteOptions(CCSVWriteOptions.Defaults()))
if include_header is not None:
self.include_header = include_header
if batch_size is not None:
self.batch_size = batch_size
if delimiter is not None:
self.delimiter = delimiter
+ if eol is not None:
+ self.eol = eol
+ if null_string is not None:
+ self.null_string = None
Review Comment:
> ???
> E TypeError: expected bytes, NoneType found
It found this glorious typo 🤦. Only have semi-working syntax highlighting
and didn't have enough time to figure out how to run the tests locally :/.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
