pitrou commented on a change in pull request #10016:
URL: https://github.com/apache/arrow/pull/10016#discussion_r613424157
##########
File path: docs/source/cpp/compute.rst
##########
@@ -250,17 +250,21 @@ Binary functions have the following semantics (which is
sometimes called
Arithmetic functions
~~~~~~~~~~~~~~~~~~~~
-These functions expect two inputs of numeric type and apply a given binary
-operation to each pair of elements gathered from the inputs. If any of the
-input elements in a pair is null, the corresponding output element is null.
-Inputs will be cast to the :ref:`common numeric type <common-numeric-type>`
+These functions expect inputs of numeric type and apply a given arithmetic
+operation to each element(s) gathered from the input(s). If any of the
+input element(s) is null, the corresponding output element is null.
+Input(s) will be cast to the :ref:`common numeric type <common-numeric-type>`
(and dictionary decoded, if applicable) before the operation is applied.
The default variant of these functions does not detect overflow (the result
then typically wraps around). Each function is also available in an
overflow-checking variant, suffixed ``_checked``, which returns
an ``Invalid`` :class:`Status` when overflow is detected.
+For a unary operation, should unsigned integer types be promoted as if in a
+binary operation with ``int8``? This would at least ensure narrowest possible
Review comment:
Please don't add questions to the documentation. The documentation is
meant to inform users, not to collect TODOs for development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
