WillAyd commented on code in PR #47313:
URL: https://github.com/apache/arrow/pull/47313#discussion_r2279919126


##########
ci/docker/linux-apt-python-313-freethreading.dockerfile:
##########
@@ -32,13 +32,18 @@ COPY python/requirements-build.txt \
 
 ENV ARROW_PYTHON_VENV /arrow-dev
 RUN python3.13t -m venv ${ARROW_PYTHON_VENV}
+
+# Free-threaded CPython 3.13 needs pinned cffi version
+RUN sed '/^cffi/d' /arrow/python/requirements-test.txt > 
/arrow/python/requirements-patched.txt && \
+    echo "cffi<2.0.0" >> /arrow/python/requirements-patched.txt

Review Comment:
   That's surprising that it only handles major and minor versions. I think the 
docs even show examples with a patch version?
   
   
https://packaging.python.org/en/latest/specifications/dependency-specifiers/#specification
   
   I wonder if including a build number here would be helpful? I'm not sure 
that Python's packaging story is complete around the `t` suffix and how version 
comparisons are handled (my knowledge could also be outdated!)



##########
ci/docker/linux-apt-python-313-freethreading.dockerfile:
##########
@@ -32,13 +32,18 @@ COPY python/requirements-build.txt \
 
 ENV ARROW_PYTHON_VENV /arrow-dev
 RUN python3.13t -m venv ${ARROW_PYTHON_VENV}
+
+# Free-threaded CPython 3.13 needs pinned cffi version
+RUN sed '/^cffi/d' /arrow/python/requirements-test.txt > 
/arrow/python/requirements-patched.txt && \
+    echo "cffi<2.0.0" >> /arrow/python/requirements-patched.txt

Review Comment:
   That's surprising that it only handles major and minor versions. I think the 
docs even show examples with a patch version?
   
   
https://packaging.python.org/en/latest/specifications/dependency-specifiers/#specification
   
   I wonder if including a patch number here would be helpful? I'm not sure 
that Python's packaging story is complete around the `t` suffix and how version 
comparisons are handled (my knowledge could also be outdated!)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to