aihuaxu opened a new pull request, #476:
URL: https://github.com/apache/arrow-go/pull/476

   ### Rationale for this change
   This is to generate the test files by reading the files from 
https://github.com/apache/parquet-testing/pull/91 and writing out the same 
files through GO implementation. 
   
   Then I tested out using Parquet-Java against those test files. 
   
   - Overall the implementation is compatible.
   - Issues:
   1. Variant logical type should write as `VARIANT(1)` instead of `VARIANT(0)` 
since the variant spec version should be 1.
   2. Type for time should `TIME(MICROS,false)` per spec, not 
`TIME(MICROS,true)`. 
   
   ```
   aixu@K7YJWY4PK6 go_variant % parquet2 meta case-032.parquet
   
   File path:  case-032.parquet
   Created by: parquet-go version 18.4.0
   Properties: (none)
   Schema:
   message schema {
     required int32 id (INTEGER(32,true)) = 1;
     optional group var (VARIANT(0)) = 2 {
       required binary metadata;
       optional binary value;
       optional int64 typed_value (TIME(MICROS,true));
     }
   }
   ```
   
   
   ### What changes are included in this PR?
   
   
   ### Are these changes tested?
   
   
   ### Are there any user-facing changes?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to