kou commented on code in PR #3296:
URL: https://github.com/apache/arrow-adbc/pull/3296#discussion_r2281212850


##########
.github/workflows/packaging.yml:
##########
@@ -1093,11 +1093,33 @@ jobs:
         env:
           ANACONDA_API_TOKEN: ${{ secrets.ANACONDA_API_TOKEN }}
 
+  # This takes a while due to sleeping to avoid rate limits, so run it first
+  # and in parallel with the builds
+  clean-gemfury:
+    name: "Remove old Gemfury packages"
+    runs-on: ubuntu-latest
+    if: github.ref == 'refs/heads/main' && (github.event.schedule || 
inputs.upload_artifacts)
+    steps:
+      - uses: actions/checkout@v5
+        with:
+          fetch-depth: 0

Review Comment:
   FYI: We can remove this because we need only the latest commit:
   
   ```suggestion
   ```



##########
.github/workflows/packaging.yml:
##########
@@ -1093,11 +1093,33 @@ jobs:
         env:
           ANACONDA_API_TOKEN: ${{ secrets.ANACONDA_API_TOKEN }}
 
+  # This takes a while due to sleeping to avoid rate limits, so run it first
+  # and in parallel with the builds
+  clean-gemfury:
+    name: "Remove old Gemfury packages"
+    runs-on: ubuntu-latest
+    if: github.ref == 'refs/heads/main' && (github.event.schedule || 
inputs.upload_artifacts)

Review Comment:
   FYI: We can use `ref_name` to simplify a condition:
   
   ```suggestion
       if: github.ref_name == 'main' && (github.event.schedule || 
inputs.upload_artifacts)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to