daniel-adam-tfs opened a new pull request, #477:
URL: https://github.com/apache/arrow-go/pull/477
### Rationale for this change
Performance improvement of reading data from RLE-dictionary encoded parquet
columns.
### What changes are included in this PR?
The DictionaryConverter interface was changed to DictionaryConverter[T]
interface, so the methods could take []T as a parameter instead of interface{}.
This required changed to several types implementing the interface.
The template code generation for RleDecoder was removed and the methods for
the parquet types are now handled by the generic TypedRleDecoder type.
Additionally, some utils.Min/utils.Max calls were replace with calls to
min/max intrinsics
### Are these changes tested?
Yes, tests verifying the RLE dictionary already existed and I've added
BenchmarkReadInt32Column to measure the performance improvement.
### Are there any user-facing changes?
Some exported types functions were changed:
DictionaryConverter -> DictionaryConverter[T]
RleDecoder -> split into RleDecoder and TypeRleDecoder[T]
func (b *BitReader) GetAligned(nbytes int, v interface{}) bool -> split into
getAlignedUint8, getAlignedUint16, getAlignedUint32, getAlignedUint64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
