zeroshade commented on code in PR #3297:
URL: https://github.com/apache/arrow-adbc/pull/3297#discussion_r2283053343
##########
go/adbc/driver/bigquery/record_reader.go:
##########
@@ -73,6 +73,12 @@ func runQuery(ctx context.Context, query *bigquery.Query,
executeUpdate bool) (b
// If there is no schema in the row iterator, then arrow
// iterator should be empty (#2173)
if iter.TotalRows > 0 {
+ if !iter.IsAccelerated() {
+ return nil, -1, adbc.Error{
+ Code: adbc.StatusUnauthorized,
+ Msg: "[bigquery] Arrow reader requires
roles/bigquery.readSessionUser, see
https://github.com/apache/arrow-adbc/issues/3282";,
+ }
+ }
Review Comment:
can we add a comment or otherwise document how `IsAccelerated` translates to
`readSessionUser`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
