alamb commented on code in PR #8161:
URL: https://github.com/apache/arrow-rs/pull/8161#discussion_r2283103947
##########
parquet-variant-json/src/from_json.rs:
##########
@@ -42,43 +39,43 @@ use serde_json::{Number, Value};
///
/// ```rust
/// # use parquet_variant::VariantBuilder;
-/// # use parquet_variant_json::{
-/// # json_to_variant, variant_to_json_string, variant_to_json,
variant_to_json_value
-/// # };
+/// # use parquet_variant_json::{JsonToVariant, VariantToJson};
///
/// let mut variant_builder = VariantBuilder::new();
/// let person_string = "{\"name\":\"Alice\", \"age\":30, ".to_string()
/// + "\"email\":\"al...@example.com\", \"is_active\": true, \"score\": 95.7,"
/// + "\"additional_info\": null}";
-/// json_to_variant(&person_string, &mut variant_builder)?;
+/// variant_builder.with_json(&person_string)?;
///
/// let (metadata, value) = variant_builder.finish();
///
/// let variant = parquet_variant::Variant::try_new(&metadata, &value)?;
///
-/// let json_result = variant_to_json_string(&variant)?;
-/// let json_value = variant_to_json_value(&variant)?;
+/// let json_result = variant.to_json_string()?;
+/// let json_value = variant.to_json_value()?;
///
/// let mut buffer = Vec::new();
-/// variant_to_json(&mut buffer, &variant)?;
+/// variant.to_json(&mut buffer)?;
/// let buffer_result = String::from_utf8(buffer)?;
/// assert_eq!(json_result,
"{\"additional_info\":null,\"age\":30,".to_string() +
///
"\"email\":\"al...@example.com\",\"is_active\":true,\"name\":\"Alice\",\"score\":95.7}");
/// assert_eq!(json_result, buffer_result);
/// assert_eq!(json_result, serde_json::to_string(&json_value)?);
/// # Ok::<(), Box<dyn std::error::Error>>(())
/// ```
-pub fn json_to_variant(json: &str, builder: &mut impl VariantBuilderExt) ->
Result<(), ArrowError> {
- let json: Value = serde_json::from_str(json)
- .map_err(|e| ArrowError::InvalidArgumentError(format!("JSON format
error: {e}")))?;
-
- build_json(&json, builder)?;
- Ok(())
+pub trait JsonToVariant {
+ /// Create a Variant from a JSON string
+ fn with_json(&mut self, json: &str) -> Result<(), ArrowError>;
Review Comment:
Can we pleae call this `append_json` to be consistent with
`VariantBuilderExt::append_value` ?
Also I think the convention of using `with_*` in these crates is for builder
/ fluent style APIs that take `self` (rather than `&mut self)`
##########
parquet-variant-json/src/from_json.rs:
##########
@@ -42,43 +39,43 @@ use serde_json::{Number, Value};
///
/// ```rust
/// # use parquet_variant::VariantBuilder;
-/// # use parquet_variant_json::{
-/// # json_to_variant, variant_to_json_string, variant_to_json,
variant_to_json_value
-/// # };
+/// # use parquet_variant_json::{JsonToVariant, VariantToJson};
///
/// let mut variant_builder = VariantBuilder::new();
/// let person_string = "{\"name\":\"Alice\", \"age\":30, ".to_string()
/// + "\"email\":\"al...@example.com\", \"is_active\": true, \"score\": 95.7,"
/// + "\"additional_info\": null}";
-/// json_to_variant(&person_string, &mut variant_builder)?;
+/// variant_builder.with_json(&person_string)?;
///
/// let (metadata, value) = variant_builder.finish();
///
/// let variant = parquet_variant::Variant::try_new(&metadata, &value)?;
///
-/// let json_result = variant_to_json_string(&variant)?;
-/// let json_value = variant_to_json_value(&variant)?;
+/// let json_result = variant.to_json_string()?;
+/// let json_value = variant.to_json_value()?;
///
/// let mut buffer = Vec::new();
-/// variant_to_json(&mut buffer, &variant)?;
+/// variant.to_json(&mut buffer)?;
/// let buffer_result = String::from_utf8(buffer)?;
/// assert_eq!(json_result,
"{\"additional_info\":null,\"age\":30,".to_string() +
///
"\"email\":\"al...@example.com\",\"is_active\":true,\"name\":\"Alice\",\"score\":95.7}");
/// assert_eq!(json_result, buffer_result);
/// assert_eq!(json_result, serde_json::to_string(&json_value)?);
/// # Ok::<(), Box<dyn std::error::Error>>(())
/// ```
-pub fn json_to_variant(json: &str, builder: &mut impl VariantBuilderExt) ->
Result<(), ArrowError> {
- let json: Value = serde_json::from_str(json)
- .map_err(|e| ArrowError::InvalidArgumentError(format!("JSON format
error: {e}")))?;
-
- build_json(&json, builder)?;
- Ok(())
+pub trait JsonToVariant {
Review Comment:
This is quite clever
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
