birschick-bq commented on code in PR #3302: URL: https://github.com/apache/arrow-adbc/pull/3302#discussion_r2285716843
########## csharp/src/Drivers/Apache/Hive2/HiveServer2Statement.cs: ########## @@ -1006,5 +1038,97 @@ public bool TryGetDirectResults(IResponse response, out TSparkDirectResults? dir directResults = null; return false; } + + /// <inheritdoc/> + public override void Cancel() + { + this.TraceActivity(activity => + { + using CancellationTokenSource cancellationTokenSource = ApacheUtility.GetCancellationTokenSource(QueryTimeoutSeconds, ApacheUtility.TimeUnit.Seconds); + try + { + // This will cancel any operation using the current token source + CancelTokenSource(); + + // Clone the operation handle so it doesn't get changed while we make our call Review Comment: No longer cloning operation handle. Will likely move the CancelOperation to the ExecuteStatement exception handler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org