raulcd commented on issue #26727: URL: https://github.com/apache/arrow/issues/26727#issuecomment-3201641676
The `DoExchange` code that generates the messages and the payloads does not reuse the code changed on server.cc here: - https://github.com/apache/arrow/pull/47115 It uses its own implementation here: https://github.com/apache/arrow/blob/066b2162206825f2d628f97f4113b0403da1f4ec/cpp/src/arrow/flight/transport_server.cc#L163-L256 I think we can do the same trick we did for DoGet were we use an internal `ipc::RecordBatchWriter` and our own `IpcPayloadWriter` to generate the `FlightPayload` so we can get rid of the manual dictionary collection and generation. @lidavidm what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
