pitrou commented on issue #47337: URL: https://github.com/apache/arrow/issues/47337#issuecomment-3201999432
> Good point. I hadn't traced all the way down to what glog does in this case and I assumed Python was aborting due to an uncaught C++ exception calling terminate. I [now see that glog is aborting though](https://github.com/google/glog/blob/master/src/logging.cc#L1900). Perhaps it would make sense for arrow to use glog's [`InstallFailureFunction`](https://github.com/google/glog/blob/53d58e4531c7c90f71ddab503d915e027432447a/src/logging.cc#L1896) to instead throw an exception rather than aborting? Since Arrow uses exceptions in other places that seems like it would be more consistent. GLog is an optional dependency. The purpose of these checks is to act just like C asserts, for example to test internal invariants. They abort on purpose. For proper error reporting, Arrow C++ uses its own `Status` class and is not meant to raise exceptions (the Parquet C++ codebase is an... exception to this rule, for historical reasons). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
