kou commented on code in PR #3115:
URL: https://github.com/apache/arrow-adbc/pull/3115#discussion_r2286837734
##########
.asf.yaml:
##########
@@ -21,6 +21,9 @@ github:
collaborators:
- krlmlr
- nbenn
+ - alexguo-db
+ - jadewang-db
+ - eric-wang-1990
Review Comment:
Could you keep this list in alphabetical order?
##########
.asf.yaml:
##########
@@ -33,6 +36,15 @@ github:
- database
protected_branches:
main: {}
+ environments:
+ databricks-e2e:
+ wait_timer: 0
+ required_reviewers:
+ - alexguo-db
+ - jadewang-db
+ - eric-wang-1990
Review Comment:
It seems that this syntax is wrong:
See also:
https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#repository-deployment-environments
```suggestion
required_reviewers:
- id: alexguo-db
type: User
- id: jadewang-db
type: User
- id: eric-wang-1990
type: User
```
##########
.github/workflows/csharp_databricks_e2e.yml:
##########
@@ -0,0 +1,147 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: C# Databricks E2E Tests
+
+on:
+ push:
+ branches: [main]
+ paths:
+ - '.github/workflows/csharp_databricks_e2e.yml'
+ - 'ci/scripts/csharp_databricks_e2e.sh'
+ - 'csharp/src/Apache.Arrow.Adbc/**'
+ - 'csharp/src/Client/**'
+ - 'csharp/src/Drivers/Apache/Hive2/**'
+ - 'csharp/src/Drivers/Apache/Spark/**'
+ - 'csharp/src/Drivers/Databricks/**'
+ - 'csharp/test/Drivers/Databricks/**'
+ pull_request_target:
+ paths:
+ - '.github/workflows/csharp_databricks_e2e.yml'
+ - 'ci/scripts/csharp_databricks_e2e.sh'
+ - 'csharp/src/Apache.Arrow.Adbc/**'
+ - 'csharp/src/Client/**'
+ - 'csharp/src/Drivers/Apache/Hive2/**'
+ - 'csharp/src/Drivers/Apache/Spark/**'
+ - 'csharp/src/Drivers/Databricks/**'
+ - 'csharp/test/Drivers/Databricks/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+ id-token: write # Required for OIDC token exchange
+
+defaults:
+ run:
+ # 'bash' will expand to -eo pipefail
+ shell: bash
+
+jobs:
+ csharp-databricks-e2e:
+ name: "C# ${{ matrix.os }} ${{ matrix.dotnet }}"
+ runs-on: ${{ matrix.os }}
+ environment: databricks-e2e
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 15
+ strategy:
+ fail-fast: false
+ matrix:
+ dotnet: ['8.0.x']
+ os: [ubuntu-latest, windows-2022, macos-13, macos-latest]
+ steps:
+ - name: Install C#
+ uses: actions/setup-dotnet@v4
+ with:
+ dotnet-version: ${{ matrix.dotnet }}
+ - name: Checkout ADBC
+ uses: actions/checkout@v4
+ with:
+ ref: ${{ github.event.pull_request.head.sha || github.sha }}
+ fetch-depth: 0
+ submodules: recursive
+ - name: Build
+ shell: bash
+ run: ci/scripts/csharp_build.sh $(pwd)
Review Comment:
Does this mean that we may run `ci/scripts/csharp_build.sh` in forked
repository with the `pull_request_target` context (that has write access to
apache/arrow-adbc)?
I think that it's not acceptable based on the ASF GitHub Actions policy:
https://infra.apache.org/github-actions-policy.html
> Triggers
>
> You MUST NOT use pull_request_target as a trigger on ANY action that
exports ANY confidential credentials or tokens such as GITHUB_TOKEN or
NPM_TOKEN.
Can we run this on fork not apache/arrow-adbc by removing `branches: [main]`
from `on.push`?
##########
.github/workflows/csharp_databricks_e2e.yml:
##########
@@ -0,0 +1,147 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: C# Databricks E2E Tests
+
+on:
+ push:
+ branches: [main]
+ paths:
+ - '.github/workflows/csharp_databricks_e2e.yml'
+ - 'ci/scripts/csharp_databricks_e2e.sh'
+ - 'csharp/src/Apache.Arrow.Adbc/**'
+ - 'csharp/src/Client/**'
+ - 'csharp/src/Drivers/Apache/Hive2/**'
+ - 'csharp/src/Drivers/Apache/Spark/**'
+ - 'csharp/src/Drivers/Databricks/**'
+ - 'csharp/test/Drivers/Databricks/**'
+ pull_request_target:
+ paths:
+ - '.github/workflows/csharp_databricks_e2e.yml'
+ - 'ci/scripts/csharp_databricks_e2e.sh'
+ - 'csharp/src/Apache.Arrow.Adbc/**'
+ - 'csharp/src/Client/**'
+ - 'csharp/src/Drivers/Apache/Hive2/**'
+ - 'csharp/src/Drivers/Apache/Spark/**'
+ - 'csharp/src/Drivers/Databricks/**'
+ - 'csharp/test/Drivers/Databricks/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+ id-token: write # Required for OIDC token exchange
+
+defaults:
+ run:
+ # 'bash' will expand to -eo pipefail
+ shell: bash
+
+jobs:
+ csharp-databricks-e2e:
+ name: "C# ${{ matrix.os }} ${{ matrix.dotnet }}"
+ runs-on: ${{ matrix.os }}
+ environment: databricks-e2e
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 15
+ strategy:
+ fail-fast: false
+ matrix:
+ dotnet: ['8.0.x']
+ os: [ubuntu-latest, windows-2022, macos-13, macos-latest]
+ steps:
+ - name: Install C#
+ uses: actions/setup-dotnet@v4
+ with:
+ dotnet-version: ${{ matrix.dotnet }}
+ - name: Checkout ADBC
+ uses: actions/checkout@v4
Review Comment:
```suggestion
uses: actions/checkout@v5
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
