amoeba commented on code in PR #3313: URL: https://github.com/apache/arrow-adbc/pull/3313#discussion_r2286920522
########## docs/source/format/driver_manifests.rst: ########## @@ -239,6 +239,83 @@ a string (single path) or a table of platform-specific paths. The ``Driver.shar needed to successfully load a driver manifest. The other keys are optional, but provide useful metadata about the driver. +Platform Tuples +^^^^^^^^^^^^^^^ + +Since the manifests use platform tuples to specify the different systems that +drivers might be built for, it is important to create a consistent way to name +these tuples. Specifically, consistent naming for operating system (OS) and +architecture combinations that can be used by all systems that read and/or write +manifest files. + +As such, the following table should be considered the authoritative list: + ++---------------+---------------+ +| OS | Tuple Name | ++===============+===============+ +| Linux | ``linux`` | ++---------------+---------------+ +| macOS | ``macos`` | ++---------------+---------------+ +| Windows | ``windows`` | ++---------------+---------------+ +| FreeBSD | ``freebsd`` | ++---------------+---------------+ +| OpenBSD | ``openbsd`` | ++---------------+---------------+ + ++---------------+-----------------+ +| Architecture | Tuple Name | ++===============+=================+ +| i386 | ``x86`` | ++---------------+-----------------+ +| x86 | ``x86`` | ++---------------+-----------------+ +| x86-64 | ``amd64`` | ++---------------+-----------------+ +| x64 | ``amd64`` | ++---------------+-----------------+ +| amd64 | ``amd64`` | ++---------------+-----------------+ +| arm (32-bit) | ``arm`` | ++---------------+-----------------+ +| armbe (32-bit)| ``armbe`` | ++---------------+-----------------+ +| arm64be | ``arm64be`` | ++---------------+-----------------+ +| aarch64 | ``arm64`` | ++---------------+-----------------+ +| arm64 | ``arm64`` | ++---------------+-----------------+ +| s390x | ``s390x`` | ++---------------+-----------------+ +| ppc | ``powerpc`` | ++---------------+-----------------+ +| ppc64 | ``powerpc64`` | ++---------------+-----------------+ +| ppc64le | ``powerpc64le`` | ++---------------+-----------------+ +| riscv | ``riscv`` | ++---------------+-----------------+ +| riscv64 | ``riscv64`` | ++---------------+-----------------+ +| sparc | ``sparc`` | ++---------------+-----------------+ +| sparc64 | ``sparc64`` | ++---------------+-----------------+ +| WASM (32-bit) | ``wasm32`` | Review Comment: ```suggestion | Wasm (32-bit) | ``wasm32`` | ``` ########## docs/source/format/driver_manifests.rst: ########## @@ -239,6 +239,83 @@ a string (single path) or a table of platform-specific paths. The ``Driver.shar needed to successfully load a driver manifest. The other keys are optional, but provide useful metadata about the driver. +Platform Tuples +^^^^^^^^^^^^^^^ + +Since the manifests use platform tuples to specify the different systems that +drivers might be built for, it is important to create a consistent way to name +these tuples. Specifically, consistent naming for operating system (OS) and +architecture combinations that can be used by all systems that read and/or write +manifest files. + +As such, the following table should be considered the authoritative list: + ++---------------+---------------+ +| OS | Tuple Name | ++===============+===============+ +| Linux | ``linux`` | ++---------------+---------------+ +| macOS | ``macos`` | ++---------------+---------------+ +| Windows | ``windows`` | ++---------------+---------------+ +| FreeBSD | ``freebsd`` | ++---------------+---------------+ +| OpenBSD | ``openbsd`` | ++---------------+---------------+ + ++---------------+-----------------+ +| Architecture | Tuple Name | ++===============+=================+ +| i386 | ``x86`` | ++---------------+-----------------+ +| x86 | ``x86`` | ++---------------+-----------------+ +| x86-64 | ``amd64`` | ++---------------+-----------------+ +| x64 | ``amd64`` | ++---------------+-----------------+ +| amd64 | ``amd64`` | ++---------------+-----------------+ +| arm (32-bit) | ``arm`` | ++---------------+-----------------+ +| armbe (32-bit)| ``armbe`` | ++---------------+-----------------+ +| arm64be | ``arm64be`` | ++---------------+-----------------+ +| aarch64 | ``arm64`` | ++---------------+-----------------+ +| arm64 | ``arm64`` | ++---------------+-----------------+ +| s390x | ``s390x`` | ++---------------+-----------------+ +| ppc | ``powerpc`` | ++---------------+-----------------+ +| ppc64 | ``powerpc64`` | ++---------------+-----------------+ +| ppc64le | ``powerpc64le`` | ++---------------+-----------------+ +| riscv | ``riscv`` | ++---------------+-----------------+ +| riscv64 | ``riscv64`` | ++---------------+-----------------+ +| sparc | ``sparc`` | ++---------------+-----------------+ +| sparc64 | ``sparc64`` | ++---------------+-----------------+ +| WASM (32-bit) | ``wasm32`` | ++---------------+-----------------+ +| WASM (64-bit) | ``wasm64`` | Review Comment: ```suggestion | Wasm (64-bit) | ``wasm64`` | ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
