scovich opened a new pull request, #8185: URL: https://github.com/apache/arrow-rs/pull/8185
# Which issue does this PR close? - Closes https://github.com/apache/arrow-rs/issues/8182 (directly) - Closes https://github.com/apache/arrow-rs/issues/8170 (as a side effect) - Closes https://github.com/apache/arrow-rs/issues/8180 (as a side effect) # Rationale for this change Make finish/rollback handling simpler, robust and uniform by pulling it inside `ParentState` (instead of each builder doing it manually) and making it fully eager (instead of a mix of eager and lazy). # What changes are included in this PR? There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. # Are these changes tested? Yes, existing unit tests cover it (including some that needed adjustment due to behavior changes), along with some new testing. # Are there any user-facing changes? `ObjectBuilder` methods `new_list` and `new_object` now panic if a duplicate field name is provided, and new fallible versions `try_new_list` and `try_new_object` are provided. `ObjectBuilder::finish` signature remains fallible, but it always returns `Result::Ok` * TODO: https://github.com/apache/arrow-rs/issues/8184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
