avm19 commented on issue #3319:
URL: https://github.com/apache/arrow-adbc/issues/3319#issuecomment-3208127593

   I think this was the change:
   
   
https://github.com/apache/arrow-adbc/commit/7804b2c47debc1740981658a12039eafe4733ada#diff-aac0b59df381ba9a1f9232bd15d9f12610bb80beb238eb51901febba5fabc066R766
   
   
https://github.com/apache/arrow-adbc/blob/7804b2c47debc1740981658a12039eafe4733ada/python/adbc_driver_manager/adbc_driver_manager/dbapi.py#L759-L769
   
   `bind()` used to be without "if". 
   
   Just thinking out loud. I guess this issue would not have arisen if 
   ```python
   elif seq_of_parameters: 
   ```
   were replaced with 
   ```python
   elif seq_of_parameters is not None: 
   ```
   I also guess that the consideration was to avoid creating an empty arrow 
batch. Anyways, it would be great if the library took care of the empty 
sequence case, so that I would not have to.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to