liamzwbao commented on code in PR #8196:
URL: https://github.com/apache/arrow-rs/pull/8196#discussion_r2289658156
##########
parquet-variant-compute/src/cast_to_variant.rs:
##########
@@ -579,6 +598,34 @@ fn process_run_end_encoded<R: RunEndIndexType>(
Ok(())
}
+/// Convert dictionary encoded arrays
+fn convert_dictionary_encoded(
Review Comment:
This change just moves the code from the `Dictionary` branch into this
helper function. Since all the impls use slightly different coding styles, we
could do a follow-up PR to make them consistent once all the variant cast
implementations are complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
