birschick-bq commented on code in PR #3315: URL: https://github.com/apache/arrow-adbc/pull/3315#discussion_r2292169337
########## csharp/src/Telemetry/Traces/Exporters/FileExporter/SerializableActivityJsonContext.cs: ########## Review Comment: @CurtHagenlocher The serialization was failing with this message: ``` "JsonTypeInfo metadata for type 'Apache.Hive.Service.Rpc.Thrift.TStatusCode' was not provided by TypeInfoResolver of type 'Apache.Arrow.Adbc.Telemetry.Traces.Exporters.FileExporter.SerializableActivityJsonContext'. If using source generation, ensure that all root types passed to the serializer have been annotated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically. The unsupported member type is located on type 'System.Object'. Path: $.TagObjects." ``` I take this to mean we'd have to know ALL the types that could be serialized ahead of time. We could be more restrictive on what we allow in the `AddTag`. Presumably restricting this to string and numeric values. I'll create a ticket to make that change in a future PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
