pitrou commented on code in PR #47350:
URL: https://github.com/apache/arrow/pull/47350#discussion_r2291443897
##########
python/pyarrow/tests/test_fs.py:
##########
@@ -1201,14 +1201,17 @@ def test_s3_options(pickle_module):
assert isinstance(fs, S3FileSystem)
assert pickle_module.loads(pickle_module.dumps(fs)) == fs
- # Note that the retry strategy won't survive pickling for now
fs = S3FileSystem(
retry_strategy=AwsStandardS3RetryStrategy(max_attempts=5))
assert isinstance(fs, S3FileSystem)
+ assert pickle_module.loads(pickle_module.dumps(fs)) == fs
+ assert fs.retry_strategy.max_attempts == 5
fs = S3FileSystem(
retry_strategy=AwsDefaultS3RetryStrategy(max_attempts=5))
assert isinstance(fs, S3FileSystem)
+ assert pickle_module.loads(pickle_module.dumps(fs)) == fs
Review Comment:
Ok, but should also assert that it's different from a filesystem configured
with another strategy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
