raulcd commented on PR #47378: URL: https://github.com/apache/arrow/pull/47378#issuecomment-3213901385
A 4% increase in `libarrow.so` size (from ~85MB to ~93MB) isn't great for memory footprint / minimal deployments, also this sets a precedent and future implications for moving functionality back from Arrow compute which isn't great. There doesn't seem to be much of an alternative though. Making this conditional would add complexity without much benefit. Breaking up `vector_swizzle.cc` also doesn't seem to be possible as both `scatter` and `inverse_permutation` are required. I can't think of any alternatives and the necessity for selection-vector-aware seems justified. We probably should have some guidelines of when/how those changes are acceptable / justified for future reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
