codephage2020 commented on code in PR #8206:
URL: https://github.com/apache/arrow-rs/pull/8206#discussion_r2293803971
##########
parquet-variant/src/builder.rs:
##########
@@ -1589,18 +1532,27 @@ impl<'a> ObjectBuilder<'a> {
/// Allows users to append values to a [`VariantBuilder`], [`ListBuilder`] or
/// [`ObjectBuilder`]. using the same interface.
pub trait VariantBuilderExt {
+ /// Appends a new variant value to this builder. See e.g.
[`VariantBuilder::append_value`].
fn append_value<'m, 'v>(&mut self, value: impl Into<Variant<'m, 'v>>);
+ /// Creates a nested list builder. See e.g. [`VariantBuilder::new_list`].
Panics if the nested
+ /// builder cannot be created, see e.g. [`ObjectBuilder::new_list`].
fn new_list(&mut self) -> ListBuilder<'_> {
self.try_new_list().unwrap()
}
+ /// Creates a nested list builder. See e.g.
[`VariantBuilder::new_object`]. Panics if the nested
+ /// builder cannot be created, see e.g. [`ObjectBuilder::new_object`].
fn new_object(&mut self) -> ObjectBuilder<'_> {
self.try_new_object().unwrap()
}
+ /// Creates a nested list builder. See e.g. [`VariantBuilder::new_list`].
Returns an error if
+ /// the nested builder cannot be created, see e.g.
[`ObjectBuilder::try_new_list`].
fn try_new_list(&mut self) -> Result<ListBuilder<'_>, ArrowError>;
+ /// Creates a nested list builder. See e.g.
[`VariantBuilder::new_object`]. Returns an error if
Review Comment:
Same as above.
##########
parquet-variant/src/builder.rs:
##########
@@ -1589,18 +1532,27 @@ impl<'a> ObjectBuilder<'a> {
/// Allows users to append values to a [`VariantBuilder`], [`ListBuilder`] or
/// [`ObjectBuilder`]. using the same interface.
pub trait VariantBuilderExt {
+ /// Appends a new variant value to this builder. See e.g.
[`VariantBuilder::append_value`].
fn append_value<'m, 'v>(&mut self, value: impl Into<Variant<'m, 'v>>);
+ /// Creates a nested list builder. See e.g. [`VariantBuilder::new_list`].
Panics if the nested
+ /// builder cannot be created, see e.g. [`ObjectBuilder::new_list`].
fn new_list(&mut self) -> ListBuilder<'_> {
self.try_new_list().unwrap()
}
+ /// Creates a nested list builder. See e.g.
[`VariantBuilder::new_object`]. Panics if the nested
Review Comment:
should be "Creates a nested object builder".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
