mbrobbel commented on code in PR #8133: URL: https://github.com/apache/arrow-rs/pull/8133#discussion_r2294418378
########## parquet/src/variant.rs: ########## @@ -0,0 +1,111 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! ⚠️ Experimental Support for reading and writing [`Variant`]s to / from Parquet files ⚠️ +//! +//! This is a 🚧 Work In Progress +//! +//! Note: Requires the `variant` feature of the `parquet` crate to be enabled. Review Comment: ```suggestion //! Note: Requires the `variant_experimental` feature of the `parquet` crate to be enabled. ``` ########## parquet/Cargo.toml: ########## @@ -124,6 +128,8 @@ encryption = ["dep:ring"] # Explicitely enabling rust_backend and zlib-rs features for flate2 flate2-rust_backened = ["flate2/rust_backend"] flate2-zlib-rs = ["flate2/zlib-rs"] +# Enable parquet variant support +variant_experimental = ["parquet-variant", "parquet-variant-json", "parquet-variant-compute"] Review Comment: Do you maybe want to add this feature to the [`experimental`](https://github.com/apache/arrow-rs/pull/8133/files#diff-80059dfe16b44840ad582c536226512e8631a13f412994f1b33d3976232fa1faR115) feature? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
