wgtmac commented on code in PR #47087: URL: https://github.com/apache/arrow/pull/47087#discussion_r2295448143
########## python/pyarrow/_parquet.pyx: ########## @@ -2408,3 +2411,77 @@ cdef class ParquetWriter(_Weakrefable): return result raise RuntimeError( 'file metadata is only available after writer close') + + @property + def properties(self): + cdef const WriterProperties* props_ptr + cdef WriterPropertiesWrapper result + + props_ptr = &self.writer.get().properties() + result = WriterPropertiesWrapper.__new__(WriterPropertiesWrapper) + result.init(props_ptr) + return result + + @property + def arrow_properties(self): + cdef ArrowWriterPropertiesWrapper result + + result = ArrowWriterPropertiesWrapper.__new__(ArrowWriterPropertiesWrapper) + result.init(self._arrow_properties) + return result + + +cdef class WriterPropertiesWrapper(_Weakrefable): Review Comment: Why is that? Is it a convention on the pyarrow side? Isn't it annoying to add a missing property in the future? cc @rok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org