alamb commented on code in PR #8208:
URL: https://github.com/apache/arrow-rs/pull/8208#discussion_r2296612336
##########
parquet-variant/src/builder.rs:
##########
@@ -589,14 +675,14 @@ enum ParentState<'a> {
Variant {
value_builder: &'a mut ValueBuilder,
saved_value_builder_offset: usize,
- metadata_builder: &'a mut MetadataBuilder,
+ metadata_builder: &'a mut dyn MetadataBuilder,
Review Comment:
> Honestly, the generic mess is messy enough that I lean strongly toward
keeping the dyn indirection unless we're really certain we need generics for
performance or functionality reasons.
I think this is a wise strategy. Let's wait for some more "end to end" type
benchmarks (like reading/writing JSON to arrays, or shredding variants) and see
if we need to try and squeeze a few more percent out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
