adamreeve commented on code in PR #8162:
URL: https://github.com/apache/arrow-rs/pull/8162#discussion_r2296830308
##########
parquet/tests/encryption/encryption_async.rs:
##########
@@ -527,28 +770,17 @@ async fn test_multi_threaded_encrypted_writing() {
// Create a temporary file to write the encrypted data
let temp_file = tempfile::tempfile().unwrap();
- let mut writer = ArrowWriter::try_new(&temp_file,
metadata.schema().clone(), props).unwrap();
+ let mut writer = ArrowWriter::try_new(&temp_file, schema.clone(),
props).unwrap();
// LOW-LEVEL API: Use low level API to write into a file using multiple
threads
// Get column writers
+ #[allow(deprecated)]
Review Comment:
If we're deprecating the old approach, rather than using
`allow(deprecated)`, I think it would be best to update this test to use the
new approach instead. Or maybe keep it but also add a new test that uses the
new approach. That way, we have a test to confirm the new API works with this
simpler parallelization strategy and won't have a gap in tested functionality
if/when the deprecated methods are removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
