wgtmac commented on code in PR #47408:
URL: https://github.com/apache/arrow/pull/47408#discussion_r2297061605
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4599,8 +4607,26 @@ target_include_directories(arrow::hadoop INTERFACE
"${HADOOP_HOME}/include")
# Apache ORC
function(build_orc)
+ list(APPEND CMAKE_MESSAGE_INDENT "Apache ORC: ")
+
message(STATUS "Building Apache ORC from source")
+ set(ORC_PATCHES)
+ if(MSVC)
+ # We can remove this once bundled Apache ORC is 2.2.1 or later.
+ list(APPEND ORC_PATCHES ${CMAKE_CURRENT_LIST_DIR}/orc-2345.patch)
+ endif()
+ if(Protobuf_VERSION VERSION_GREATER_EQUAL 32.0)
+ # We can remove this once bundled Apache ORC is 2.2.1 or later.
+ list(APPEND ORC_PATCHES ${CMAKE_CURRENT_LIST_DIR}/orc-2357.patch)
+ endif()
+ if(ORC_PATCHES)
+ find_program(PATCH patch REQUIRED)
Review Comment:
I recall that there are some docker images required to add patch dependency
when I was fixing a previous ORC build failure. Is it still the case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
