adamreeve commented on code in PR #20:
URL: https://github.com/apache/arrow-dotnet/pull/20#discussion_r2297625991
##########
.pre-commit-config.yaml:
##########
@@ -35,3 +35,10 @@ repos:
rm -f apache-arrow-dotnet.tar.gz"
always_run: true
pass_filenames: false
+ - id: format
+ name: Format
+ language: system
+ entry: |
+ dotnet format --exclude --exclude
src/Apache.Arrow/Flatbuf/FlatBuffers/
Review Comment:
I think the extra exclude is unintentional?
```suggestion
dotnet format --exclude src/Apache.Arrow/Flatbuf/FlatBuffers/
```
##########
test/Apache.Arrow.Tests/BooleanArrayTests.cs:
##########
@@ -134,10 +134,10 @@ public void SwapsExpectedBits()
Assert.False(array.GetValue(0).Value);
Assert.True(array.GetValue(7).HasValue);
Assert.True(array.GetValue(7).Value);
- #pragma warning disable CS0618
+#pragma warning disable CS0618
Review Comment:
I think this is fine. I'd probably prefer the original format with indent
but it doesn't look like that's supported by dotnet format, although JetBrains
Resharper has a custom extension to support this:
https://www.jetbrains.com/help/resharper/EditorConfig_CSHARP_CSharpIndentStylePageSchema.html#resharper_csharp_indent_preprocessor_other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
