sgilmore10 commented on code in PR #47316:
URL: https://github.com/apache/arrow/pull/47316#discussion_r2298161924
##########
cpp/src/parquet/properties.h:
##########
@@ -1256,12 +1257,28 @@ class PARQUET_EXPORT ArrowWriterProperties {
return this;
}
+ /// \brief Write time32 and time64 columns whose isAdjustedToUTC field is
true.
+ ///
+ /// \note Does not apply to timestamp columns.
+ Builder* enable_time_adjusted_to_utc() {
+ write_time_adjusted_to_utc_ = true;
+ return this;
+ }
Review Comment:
Will do!
I was following the existing `enable_*` and `disable_*` pattern used for
other `true|false` properties, but adding a method that accepts a `bool` input
argument is more efficient.
##########
cpp/src/parquet/properties.h:
##########
@@ -1256,12 +1257,28 @@ class PARQUET_EXPORT ArrowWriterProperties {
return this;
}
+ /// \brief Write time32 and time64 columns whose isAdjustedToUTC field is
true.
+ ///
+ /// \note Does not apply to timestamp columns.
+ Builder* enable_time_adjusted_to_utc() {
+ write_time_adjusted_to_utc_ = true;
+ return this;
+ }
Review Comment:
Will do!
I was following the existing `enable_*` and `disable_*` pattern used for
other `true|false` properties, but adding a method that accepts a `bool` input
argument is more succinct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
