scovich commented on code in PR #8214:
URL: https://github.com/apache/arrow-rs/pull/8214#discussion_r2298292112


##########
parquet-variant/src/builder.rs:
##########
@@ -1994,15 +1980,15 @@ mod tests {
         {
             let mut object_builder = list_builder.new_object();
             object_builder.insert("a", 1);
-            let _ = object_builder.finish();

Review Comment:
   Yipes -- the original code was buggy, ignoring a `Result`!
   
   (fortunately it doesn't matter any more)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to