pitrou commented on code in PR #47185:
URL: https://github.com/apache/arrow/pull/47185#discussion_r2298583259
##########
cpp/src/parquet/decoder.cc:
##########
@@ -2072,6 +2072,15 @@ class DeltaByteArrayDecoderImpl : public
TypedDecoderImpl<DType> {
std::vector<ByteArray> values(num_values);
const int num_valid_values = GetInternal(values.data(), num_values -
null_count);
DCHECK_EQ(num_values - null_count, num_valid_values);
+ if constexpr (std::is_same_v<DType, FLBAType>) {
Review Comment:
Should `DeltaLengthByteArrayDecoder` also get the same checks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
