jonkeane commented on PR #47423: URL: https://github.com/apache/arrow/pull/47423#issuecomment-3221577318
> > > we end up losing lintr's object_length_linter and cyclocomp_linter, but it seems reasonable to enforce these conventions via code review anyway. > > > > Agreed. We had already been setting the cyclocomp pretty high anyway, I'm not sure there's much value in it. I'm a little surprised by the object length linter going away? > > I had a bit more of a read and I think the nuance is that a styler/formatter and a linter are different things, and so air replaces styler not lintr, which I guess makes sense as there are some things lintr can pick up that styler can't fix, we just don't end up encountering them as much on arrow. Ah, yep yep that's right ok cool! I'm still fine 🚮 the cyclocomp lintr even if we keep the others that will enforce (for folks who haven't installed the pre-commit hook or who override it, etc.) our styling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
