alamb commented on code in PR #8141:
URL: https://github.com/apache/arrow-rs/pull/8141#discussion_r2300557499
##########
parquet-variant/src/builder.rs:
##########
@@ -1470,6 +1508,45 @@ impl<'a> ObjectBuilder<'a> {
ValueBuilder::try_append_variant(state, value.into())
}
+ /// Add a field with key and value to the object by copying raw bytes when
possible.
+ ///
+ /// For objects and lists, this directly copies their underlying byte
representation instead of
+ /// performing a logical copy, and without touching the metadata builder.
For other variant
+ /// types, this falls back to the standard append behavior.
+ ///
+ /// The caller must ensure that the metadata dictionary is already built
and correct for
+ /// any objects or lists being appended, but the value's new field name is
handled normally.
+ ///
+ /// # Panics
+ ///
+ /// This method will panic if the variant contains duplicate field names
in objects
+ /// when validation is enabled. For a fallible version, use
[`ObjectBuilder::try_insert_bytes`]
+ pub fn insert_bytes<'m, 'd>(&mut self, key: &str, value: impl
Into<Variant<'m, 'd>>) {
+ self.try_insert_bytes(key, value).unwrap()
+ }
+
+ /// Add a field with key and value to the object by copying raw bytes when
possible.
+ ///
+ /// For objects and lists, this directly copies their underlying byte
representation instead of
+ /// performing a logical copy, and without touching the metadata builder.
For other variant
+ /// types, this falls back to the standard append behavior.
+ ///
+ /// The caller must ensure that the metadata dictionary is already built
and correct for
+ /// any objects or lists being appended, but the value's new field name is
handled normally.
+ ///
+ /// # Note
Review Comment:
Is this note still valid? I think there is no inserting of keys that happens
via this API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
