mbrobbel commented on code in PR #8232:
URL: https://github.com/apache/arrow-rs/pull/8232#discussion_r2303734709
##########
parquet-variant/src/variant.rs:
##########
@@ -915,6 +916,37 @@ impl<'m, 'v> Variant<'m, 'v> {
_ => None,
}
}
+
+ /// Converts this variant to an `f16` if possible.
+ ///
+ /// Returns `Some(f16)` for float and double variants,
+ /// `None` for non-floating-point variants.
+ ///
+ /// # Example
+ ///
+ /// ```
+ /// use parquet_variant::Variant;
+ /// use half::f16;
+ ///
+ /// // you can extract a f16 from a float variant
Review Comment:
```suggestion
/// // you can extract an f16 from a float variant
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
