zeroshade commented on code in PR #485:
URL: https://github.com/apache/arrow-go/pull/485#discussion_r2304386592
##########
parquet/file/column_reader.go:
##########
@@ -113,6 +113,8 @@ type ColumnChunkReader interface {
// automatically read the first page of the page reader passed in until
// HasNext which will read in the next page.
setPageReader(PageReader)
+ // Close releases the resources held by the column reader.
+ Close()
Review Comment:
if we're adding a `Close()` method to the reader we should follow the
convention and the signature should be `Close() error`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
