CurtHagenlocher commented on code in PR #3358:
URL: https://github.com/apache/arrow-adbc/pull/3358#discussion_r2305180382
##########
csharp/test/Drivers/Apache/Common/ClientTests.cs:
##########
@@ -45,7 +45,10 @@ public ClientTests(ITestOutputHelper? outputHelper,
TestEnvironment<TConfig>.Fac
{
Skip.IfNot(Utils.CanExecuteTestConfig(TestConfigVariable));
}
-
+ internal virtual string formatTableName()
Review Comment:
nits: capitalize method name and put blank lines before and after method
definition.
Consider replacing the method with a property, e.g.
```
internal virtual string FormatTableName => TestConfiguration.Metadata.Table;
```
and
```
internal override string FormatTableName =>
$"{TestConfiguration.Metadata.Catalog}.{TestConfiguration.Metadata.Schema}.{TestConfiguration.Metadata.Table}";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
