bgilbert commented on code in PR #803:
URL: https://github.com/apache/arrow-nanoarrow/pull/803#discussion_r2305220804
##########
meson.build:
##########
@@ -21,7 +21,7 @@ project(
'cpp',
version: '0.8.0-SNAPSHOT',
license: 'Apache 2.0',
Review Comment:
SPDX license expression is preferred.
```suggestion
license: 'Apache-2.0',
```
##########
meson.build:
##########
@@ -21,7 +21,7 @@ project(
'cpp',
version: '0.8.0-SNAPSHOT',
license: 'Apache 2.0',
- meson_version: '>=1.3.0',
+ meson_version: '>=1.1.0',
Review Comment:
`meson.options` is undoubtedly a nicer name but IMO it's not worth
constraining the Meson version just to avoid `meson_options.txt`.
##########
meson.build:
##########
@@ -135,11 +143,14 @@ if get_option('ipc').enabled()
c_args: ipc_lib_c_args,
gnu_symbol_visibility: 'hidden',
)
+ pkg.generate(nanoarrow_ipc_lib, filebase: 'nanoarrow-ipc')
+
nanoarrow_ipc_dep = declare_dependency(
include_directories: [incdir],
link_with: nanoarrow_ipc_lib,
dependencies: [nanoarrow_dep],
)
+ meson.override_dependency('nanoarrow-ipc', nanoarrow_dep)
Review Comment:
```suggestion
meson.override_dependency('nanoarrow-ipc', nanoarrow_ipc_dep)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
