adamreeve commented on code in PR #28:
URL: https://github.com/apache/arrow-dotnet/pull/28#discussion_r2305436185


##########
dev/release/rat_exclude_files.txt:
##########
@@ -20,3 +20,4 @@
 *.sln
 .github/pull_request_template.md
 src/Apache.Arrow/Flatbuf/*
+docs/images/*

Review Comment:
   I'm not sure what the rules are on which files can be excluded, but it seems 
unnecessary to have the licence header in an SVG?
   
   Also, I should mention that favicon.svg was not created by me, I downloaded 
it from https://arrow.apache.org/visual_identity/ and just modified the height 
and width to fit in the header. Does this need to be documented anywhere?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to