zanmato1984 commented on code in PR #47445:
URL: https://github.com/apache/arrow/pull/47445#discussion_r2307185284
##########
cpp/src/arrow/compute/kernels/scalar_arithmetic.cc:
##########
@@ -670,7 +670,6 @@ void AddDecimalBinaryKernels(const std::string& name,
ScalarFunction* func) {
out_type = OutputType(ResolveDecimalMultiplicationOutput);
} else if (op == "divide") {
out_type = OutputType(ResolveDecimalDivisionOutput);
- constraint = BinaryDecimalScale1GeScale2();
Review Comment:
And this is how we obey the resulting type rule we claim - promoting the
dividend.
That said, there is an alternative though - as you implied in your previous
comment
> looks like an exact match in this example. The result type is unrelated to
this.
This is also explained in my PR description approach 2. I didn't take that
approach because that would require the promotion to happen during the
underlying division for each individual value in the array. Can be cumbersome
in terms of both coding and performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
