lidavidm commented on code in PR #3362:
URL: https://github.com/apache/arrow-adbc/pull/3362#discussion_r2308822035


##########
c/driver/sqlite/sqlite_test.cc:
##########
@@ -826,6 +828,32 @@ TEST_F(SqliteReaderTest, InferTypedParams) {
                   "[SQLite] Type mismatch in column 0: expected INT64 but got 
DOUBLE"));
 }
 
+TEST_F(SqliteReaderTest, BindByName) {
+  adbc_validation::StreamReader reader;
+  Handle<struct ArrowSchema> schema;
+  Handle<struct ArrowArray> batch;
+
+  ASSERT_THAT(adbc_validation::MakeSchema(&schema.value,
+                                          {
+                                              {"@b", NANOARROW_TYPE_INT64},

Review Comment:
   We technically ignore that part of DBAPI and just pass through whatever the 
underlying vendor uses. 
   
   The driver should support all the syntaxes now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to