zeroshade commented on code in PR #3366:
URL: https://github.com/apache/arrow-adbc/pull/3366#discussion_r2310367343


##########
python/adbc_driver_snowflake/adbc_driver_snowflake/__init__.py:
##########
@@ -104,6 +106,27 @@ class DatabaseOptions(enum.Enum):
     USE_HIGH_PRECISION = "adbc.snowflake.sql.client_option.use_high_precision"
 
 
+class ValueAuth(enum.Enum):

Review Comment:
   I was mostly following the existing pattern we had from above. In addition, 
I named it `ValueAuth` because that's what the existing documentation 
referenced, even though it didn't exist lol 
   
   I'm happy to change the name though



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to