visr commented on issue #559: URL: https://github.com/apache/arrow-julia/issues/559#issuecomment-3237384917
It seems that on unreleased julia versions the logging is a lot faster already, but still ~40 slower than without the log (`to_datetime` performance seems stable): ```jl @b convert(DateTime, ts) # 6.525 μs (119 allocs: 6.719 KiB) julia 1.11.6 @b convert(DateTime, ts) # 55.349 ns (1 allocs: 16 bytes) julia 1.12.0-rc1.45 @b convert(DateTime, ts) # 53.556 ns (1 allocs: 16 bytes) julia 1.13.0-DEV.1055 ``` It seems most of the damage comes from [`fixup_stdlib_path`](https://github.com/JuliaLang/julia/blob/4d7da74f16a7b84e52d0f0e6ce35ef9e5d859d1a/base/logging/logging.jl#L410), which comes before the [maxlog handling](https://github.com/JuliaLang/julia/blob/4d7da74f16a7b84e52d0f0e6ce35ef9e5d859d1a/base/logging/logging.jl#L696-L703), which seems to be up to the logger type to implement. Generating the message is costly, and maxlog cannot prevent this. Though I should add that from a UX perspective I'd also rather not have a warning here, either error or nothing, and given that error would be quite breaking, just documenting the behavior has my preference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
