willtemperley commented on code in PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#discussion_r2311772941
##########
Tests/ArrowTests/IPCTests.swift:
##########
@@ -329,7 +329,7 @@ final class IPCFileReaderTests: XCTestCase { //
swiftlint:disable:this type_body
}
func testFileReader_struct() throws {
- let fileURL =
currentDirectory().appendingPathComponent("../../testdata_struct.arrow")
+ let fileURL =
currentDirectory().appendingPathComponent("../testdata_struct.arrow")
Review Comment:
The arrow test files probably need to be added to the repo - I'm getting 6
tests failing in IPCFileReaderTests:
testFileReader_double
testFileReader_bool
testFileWriter_bool
testFileReader_struct
testFileWriter_struct
##########
Package.swift:
##########
@@ -23,67 +23,69 @@ import PackageDescription
let package = Package(
name: "Arrow",
platforms: [
- .macOS(.v10_15)
+ .macOS(.v10_15),
],
products: [
.library(
name: "Arrow",
- targets: ["Arrow"])
+ targets: ["Arrow"]
+ ),
],
dependencies: [
.package(url: "https://github.com/google/flatbuffers.git";, from:
"25.2.10"),
.package(url: "https://github.com/grpc/grpc-swift.git";, from:
"1.25.0"),
.package(url: "https://github.com/apple/swift-protobuf.git";, from:
"1.29.0"),
- .package(url: "https://github.com/apple/swift-atomics.git";, from:
"1.3.0")
+ .package(url: "https://github.com/apple/swift-atomics.git";, from:
"1.3.0"),
],
targets: [
.target(
name: "ArrowC",
- path: "Arrow/Sources/ArrowC",
swiftSettings: [
// build: .unsafeFlags(["-warnings-as-errors"])
]
),
.target(
name: "Arrow",
- dependencies: ["ArrowC",
- .product(name: "FlatBuffers", package:
"flatbuffers"),
- .product(name: "Atomics", package: "swift-atomics")
+ dependencies: [
+ .target(name: "ArrowC"),
+ .product(name: "FlatBuffers", package: "flatbuffers"),
+ .product(name: "Atomics", package: "swift-atomics"),
],
- path: "Arrow/Sources/Arrow",
swiftSettings: [
// build: .unsafeFlags(["-warnings-as-errors"])
]
),
.target(
name: "ArrowFlight",
dependencies: [
- "Arrow",
+ .target(name: "Arrow"),
.product(name: "GRPC", package: "grpc-swift"),
- .product(name: "SwiftProtobuf", package: "swift-protobuf")
+ .product(name: "SwiftProtobuf", package: "swift-protobuf"),
],
- path: "ArrowFlight/Sources/ArrowFlight",
swiftSettings: [
// build: .unsafeFlags(["-warnings-as-errors"])
]
),
+ .executableTarget(
Review Comment:
I think go-swift should be a plain .target, not an .executableTarget. It
doesn’t define a Swift entrypoint (main.swift/@main), so building it as an
executable fails with _main linker errors. I'm guessing the actual entrypoint
is in Go (main.go), with Swift providing a library layer that Go consumes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
