andishgar commented on code in PR #47204:
URL: https://github.com/apache/arrow/pull/47204#discussion_r2311949306
##########
cpp/src/arrow/record_batch_test.cc:
##########
@@ -62,7 +63,49 @@ using util::Float16;
class TestRecordBatch : public ::testing::Test {};
TEST_F(TestRecordBatch, Equals) {
- const int length = 10;
+ int length = 10;
Review Comment:
In the Google C++ style guide, it says that it is better **not** to use
[`const` on local
variables](https://google.github.io/styleguide/cppguide.html#Use_of_const):
> *We strongly recommend using `const` in APIs (i.e., on function
parameters, methods, and non-local variables) wherever it is meaningful and
accurate.*
Although `const` seems meaningful here, should I revert the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
