kou commented on PR #77: URL: https://github.com/apache/arrow-swift/pull/77#issuecomment-3239729144
We don't need to add auto generated files: [0001-Don-t-add-auto-generated-files.patch](https://github.com/user-attachments/files/22062446/0001-Don-t-add-auto-generated-files.patch) (You can apply it by `git am < 0001-Don-t-add-auto-generated-files.patch`.) ```diff From 76bef0db149c659e2c53c1c1b5e86257b737fa2d Mon Sep 17 00:00:00 2001 From: Sutou Kouhei <[email protected]> Date: Sun, 31 Aug 2025 12:38:20 +0900 Subject: [PATCH] Don't add auto generated files --- .../ArrowTests/Resources/testdata_bool.arrow | Bin 650 -> 0 bytes .../Resources/testdata_double.arrow | Bin 698 -> 0 bytes .../Resources/testdata_struct.arrow | Bin 810 -> 0 bytes ci/scripts/build.sh | 25 +++++++++++++----- 4 files changed, 19 insertions(+), 6 deletions(-) delete mode 100644 Tests/ArrowTests/Resources/testdata_bool.arrow delete mode 100644 Tests/ArrowTests/Resources/testdata_double.arrow delete mode 100644 Tests/ArrowTests/Resources/testdata_struct.arrow diff --git a/Tests/ArrowTests/Resources/testdata_bool.arrow b/Tests/ArrowTests/Resources/testdata_bool.arrow deleted file mode 100644 index 8dd4a94868da76305004f4513748cda452bfb462..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 650 zcmc&y%L&3j5PfRmkAPo9umKNV1dkqK1%ekVh<Gv(6v0X?!7@C0@L&P<qVMg_20L)V z%bT5FW@fY6Y}VU3@S$7*bP1r1glHk++iaBxO+KK_zkw=GOJ@Pz%vY|@N1RZXJZZ0y zkLR4eq4RgFLWm!_NYpKtU(f?6FF$0?tNtF;ESCL^s1L{y0i-Uf^w-q+n4Tv6nn8Jc zBDOfuudeS&G@GR2Da>Q1az57fGBqBQ5q>YBcBm81A#7qwFBr(`p+TtM4xyTttjM_o yuJ5=nvTT>13R?YriM6wY)Aemu?LxL0u^?1cJ=~lQyo^)hK>xbiI~!QJfA9<Osx~qJ diff --git a/Tests/ArrowTests/Resources/testdata_double.arrow b/Tests/ArrowTests/Resources/testdata_double.arrow deleted file mode 100644 index 011afd14f120d681c5c5887f6b1d4bbc97549d95..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 698 zcmd5)J5B>Z41Js3gb+pI7e#64DJYVTj!8#{v`x6cMyXh76@<i1NR=aSjFgmIBPW3O zJhp^50Uo{acRaRdmUaEOS^(dqJ%Dop7-3ADqT=qhqQa01wB;S>QA=h4zIa||Cj_aV z^C(&iD2eTB%ls3&<IJ-tPM8s-(mBNeBL-Zeo}F)>8>{m`i{HaKr<AYAD*|{@ILZB` zI+)Qjq+h+rz9ITV&~G_x!Eam$UbsGY9`!!B9(_yIeE#MRJ@V|{MaTQhi?lWxrL12h z<pHMYIt#XIp27*Co^|J2)3u!McGES@x_#;No-~_p%&sqe1`&Tt-<<-ONws{K4179| QIl5}>KfJ%{TiT!f0k*(B?EnA( diff --git a/Tests/ArrowTests/Resources/testdata_struct.arrow b/Tests/ArrowTests/Resources/testdata_struct.arrow deleted file mode 100644 index b35387dc4f2cb68004e32083b46aff3a5b41e580..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 810 zcmdUuy-EW?6opUB8dq6SG)T&n78bFyG`%3CvDZQbHJ}l+_faf;5Fa6rVCfsg@66mQ z*x7oPGk5Npx$|>&cRHJ$UmQy-u#~h5r7d-EQw?osy+$pM&}u97N+!Ki>$(vH+pjch z@C;giWBioZz-7#>`)JUi86W5y#JiXA<$Qii-LTZ|#BQE%4k1{Nde-zK&RS|87Y{f0 z*T3?os|7jBuRe)U&;1VQ?-Ls+oj@bT`@Z>zk(P0LVEq~PVPcRSqR(L18^hihdCrXE zqE>(0J&Zi-Cy{5pQ}3DkrvBGF=Xo91`n{MF-no(E)(rdP=<{~mdM`Y%N7jyD^{OfB X*;C`Ih94gzE#W_ZH!Y@3%RllBNe@lz diff --git a/ci/scripts/build.sh b/ci/scripts/build.sh index 3343f9a..770b93f 100755 --- a/ci/scripts/build.sh +++ b/ci/scripts/build.sh @@ -43,13 +43,26 @@ if [ -d /cache ]; then fi github_actions_group_end +github_actions_group_begin "Generate data" +data_gen_dir="${build_dir}/source/data-generator/swift-datagen" +if [ -d /cache ]; then + export GOCACHE="/cache/go-build" + export GOMODCACHE="/cache/go-mod" +fi +export GOPATH="${build_dir}" +pushd "${data_gen_dir}" +go get -d ./... +go run . +mkdir -p ../../Tests/ArrowTests/Resources/ +cp *.arrow ../../Tests/ArrowTests/Resources/ +popd +github_actions_group_end + github_actions_group_begin "Use -warnings-as-errors" -for package in . Arrow ArrowFlight; do - pushd "${build_dir}/source/${package}" - sed 's/\/\/ build://g' Package.swift > Package.swift.build - mv Package.swift.build Package.swift - popd -done +pushd "${build_dir}/source" +sed 's/\/\/ build://g' Package.swift > Package.swift.build +mv Package.swift.build Package.swift +popd github_actions_group_end github_actions_group_begin "Build" -- 2.50.1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
