lidavidm commented on code in PR #3370:
URL: https://github.com/apache/arrow-adbc/pull/3370#discussion_r2312827418
##########
java/driver/jni/src/main/java/org/apache/arrow/adbc/driver/jni/JniStatement.java:
##########
@@ -40,6 +44,18 @@ public void setSqlQuery(String query) throws AdbcException {
JniLoader.INSTANCE.statementSetSqlQuery(handle, query);
}
+ @Override
+ public void bind(VectorSchemaRoot root) throws AdbcException {
+ try (final ArrowArray batch = ArrowArray.allocateNew(allocator);
+ final ArrowSchema schema = ArrowSchema.allocateNew(allocator)) {
+ // TODO(lidavidm): we may need a way to separately provide a dictionary
provider
Review Comment:
It will already error since we don't provide a dictionary provider. But the
APIs here need to be reconsidered a bit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
