Dandandan commented on pull request #10046: URL: https://github.com/apache/arrow/pull/10046#issuecomment-820485697
> This PR removes the bound checks as discussed in #9994. > > Furthermore I added `unsafe` versions of the `value` method to `PrimitiveArray` and `BooleanArray`. The `safe` marked methods are actually `unsafe`. This way we can slowly transition to explicitly using the `unsafe` variant and later make the "safe" one truly safe. > > For the time being I also added a `debug_assert` bounds check in those "safe" methods that are `unsafe`. That way we at least get a panic in debug mode instead of UB in safe code. This is great! I think this is a great improvement from the `unsafe` standpoint, and this helps us limit the unsafe method only in places where it's needed (iterators/hot loops)! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
