mathyingzhou commented on a change in pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#discussion_r614156557
##########
File path: cpp/src/arrow/adapters/orc/adapter_test.cc
##########
@@ -15,20 +15,44 @@
// specific language governing permissions and limitations
// under the License.
-#include <string>
-
#include "arrow/adapters/orc/adapter.h"
-#include "arrow/array.h"
-#include "arrow/io/api.h"
#include <gtest/gtest.h>
+
#include <orc/OrcFile.hh>
+#include <string>
+
+#include "arrow/adapters/orc/adapter_util.h"
+#include "arrow/array.h"
+#include "arrow/buffer.h"
+#include "arrow/buffer_builder.h"
+#include "arrow/chunked_array.h"
+#include "arrow/compute/cast.h"
Review comment:
It actually does. Arrow has a lot more types than ORC hence
Arrow2ORC(ORC2Arrow(x)) may not be the same as x. As a result we have to have
casting for testing purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
