rok commented on a change in pull request #9758:
URL: https://github.com/apache/arrow/pull/9758#discussion_r614157498
##########
File path: cpp/src/arrow/compute/kernels/aggregate_test.cc
##########
@@ -399,6 +498,13 @@ TYPED_TEST_SUITE(TestMeanKernelNumeric, NumericArrowTypes);
TYPED_TEST(TestMeanKernelNumeric, SimpleMean) {
using ScalarType = typename TypeTraits<DoubleType>::ScalarType;
+ const ScalarAggregateOptions& options =
+ ScalarAggregateOptions(ScalarAggregateOptions::SKIPNA, 0);
+
+ ValidateMean<TypeParam>("[]", Datum(std::make_shared<ScalarType>(0)),
options);
Review comment:
Agreed. I think I've put it there to have it documented while I was
changing other things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
